Minor issues (1.0.1.0)

Posted by Community Admin on 05-Aug-2018 17:02

Minor issues (1.0.1.0)

Sitefinity - Front- & Back-End Development

All Replies

Posted by Community Admin on 12-Mar-2012 00:00

Hey all,

After a week of using Thunder with a small 'SBE' project I wanted to throw some stuff out there...


Thunder connection
Although testing a connection with a non 'admin' user is succesful, retrieval of themes is also succesful - publishing as a non admin fails. This results in error.log message like this:

Message: HandlingInstanceID: 29c0c840-b047-4bd3-8559-256f63fb2ae4
An exception of type 'System.UnauthorizedAccessException' occurred and was caught.
----------------------------------------------------------------------------------
03/09/2012 11:52:23
Type : System.UnauthorizedAccessException, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
Message : Access to the path 'C:\iis.tld\instancename\www_d\App_Data\Sitefinity\WebsiteTemplates\Thunder\App_Themes\myTheme/fonts/' is denied.
Source : mscorlib
Help link :
Data : System.Collections.ListDictionaryInternal
TargetSite : Void WinIOError(Int32, System.String)
Stack Trace :    at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.Directory.InternalCreateDirectory(String fullPath, String path, Object dirSecurityObj)
   at System.IO.Directory.CreateDirectory(String path)
   at Telerik.Sitefinity.Utilities.Zip.ZipEntry.ValidateOutput(String basedir, Stream outstream, String& OutputFile)
   at Telerik.Sitefinity.Utilities.Zip.ZipEntry.InternalExtract(String baseDir, Stream outstream, String password)
   at Telerik.Sitefinity.Utilities.Zip.ZipFile.ExtractAll(String path, Boolean wantOverwrite)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.Storage.FileSystem.ZipFileCompressionHelper.UnCompress(Byte[] bytes, String dirPath)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.Storage.FileSystem.FileSystemThemesStorageProvider.Save(Theme theme, String path)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.ThemesManager.SaveTheme(Theme theme)
   at Telerik.Sitefinity.Thunder.Module.Services.ThunderFacade.SaveTheme(Theme theme)
   at Telerik.Sitefinity.Thunder.Module.Services.ThunderService.SaveTheme(String themeName, String type, Stream themeDataStream)


Thunder upload failing
Whenever the folder is being viewed in a Windows Explorer, uploading fails. After failure of upload you end up with the theme completely removed. (and thus the site being broken)

Message: HandlingInstanceID: 2dd8f34a-4499-4ab2-98ec-dfaf751b38b8
An exception of type 'System.IO.IOException' occurred and was caught.
---------------------------------------------------------------------
03/09/2012 11:52:15
Type : System.IO.IOException, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
Message : De map is niet leeg.   (remark: 'folder isn't empty' message in dutch)
 
Source : mscorlib
Help link :
Data : System.Collections.ListDictionaryInternal
TargetSite : Void WinIOError(Int32, System.String)
Stack Trace :    at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.Directory.DeleteHelper(String fullPath, String userPath, Boolean recursive)
   at System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.Storage.FileSystem.FileSystemThemesStorageProvider.DeleteDirectory(String targetDir)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.Storage.FileSystem.FileSystemThemesStorageProvider.Save(Theme theme, String path)
   at Telerik.Sitefinity.Thunder.Module.Services.Areas.Themes.ThemesManager.SaveTheme(Theme theme)
   at Telerik.Sitefinity.Thunder.Module.Services.ThunderFacade.SaveTheme(Theme theme)
   at Telerik.Sitefinity.Thunder.Module.Services.ThunderService.SaveTheme(String themeName, String type, Stream themeDataStream)

Thunder statusbar message
The Visual Studio 2010 status bar 'flashes' a succesful update but ends up with displaying 'Successfully loaded the themes from ....' so unless you noticed the flashed message, there's no way of telling wether an upload was succesful.

VisualStudio Solution Explorer
Right clicking on a Thunder projects solution folder gives the ability to 'upload' but nowhere is visible where it is being uploaded to.

VisualStudio Thunder project
Although on a file level, a Thunder project starts at /App_Data/Sitefinity/WebsiteTemplates it only allows for the subsequent 'App_Themes' folder to be published.

Technically themes and masterpages/widgets are seperated but from a Marketplace point of View, Thunder would allow for the full 'Theme/Template combination'. That way we can have our 'normal project' seperated from our 'presentation parts'.

Or in short: I'd like to be able to have everything under Sitefinity/WebsiteTemplates/ThunderProjectName as a Thunder Project

Jochem.

Posted by Community Admin on 14-Mar-2012 00:00

Hello Jochem,

Thank you for your time and the feedback you provide.

  • About the 1st issue - currently Thunder requires administrator account in order to work. We'll work on the UI and the messages to improve this.
  • Windows Explorer - this is kind of classic problem - Explorer "locks" the folders also this can happen if for some reason you have command prompt opened with this folder. This will remain like a known issue since we don't have much to do (solutions are to "kill" the Explorer process or not to delete the folders.
  • Status bar message and the solution explorer - you're completely right and we'll work on this. You can check the output window too, there is Sitefinity Thunder category where the operations are logged.

About the Thunder project under App_Data/Sitefinity/WebsiteTemplates. We stared this custom project type (Sitefinity Themes) exactly with the idea that in the future we'll have the templates and the themes in a separate project which will allow the separation that you're talking about, the remote operations and some more.


Kind regards,
Pavel Iliev
the Telerik team
Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items

Posted by Community Admin on 14-Mar-2012 00:00

Hey Pavel,

Thanks for the explanation!
With regard to the first issue ( I think on one specific occasion I had both issue 1 & 2) but had to resort to manually take ownership of the folder again to get things working again.

I'm not sure how you guys handle a backup & update, but since a backup is successfully made but the upload fails you end up with a broken site. Ideally if an update fails, the backup is restored but (in combination with point 3) an annoying "Hey the upload failed - your site is now broken" pop-up would be great.

Jochem.


Posted by Community Admin on 20-Mar-2012 00:00

Hi Jochem,

This will be a good improvement and we'll add it either in the upcoming release or the one after it. 

Kind regards,
Pavel Iliev
the Telerik team

Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items

This thread is closed